feat: Add Scope attributes into log #6834
Merged
+50
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
itaybre
requested review from
noahsmartin,
philipphofmann and
philprime
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6834 +/- ##
=============================================
- Coverage 85.102% 85.065% -0.038%
=============================================
Files 453 453
Lines 27655 27660 +5
Branches 12146 12148 +2
=============================================
- Hits 23535 23529 -6
- Misses 4075 4088 +13
+ Partials 45 43 -2
... and 4 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e7a30b0 | 1222.93 ms | 1255.40 ms | 32.47 ms |
| 795dd39 | 1216.88 ms | 1245.47 ms | 28.59 ms |
| ea12acf | 1217.67 ms | 1252.69 ms | 35.03 ms |
| 762a701 | 1225.95 ms | 1244.49 ms | 18.54 ms |
| 73c9712 | 1238.57 ms | 1260.38 ms | 21.80 ms |
| 26f7b17 | 1218.47 ms | 1253.82 ms | 35.35 ms |
| 924de23 | 1222.84 ms | 1248.37 ms | 25.54 ms |
| cda95fc | 1231.42 ms | 1247.18 ms | 15.77 ms |
| 7cc23cf | 1203.15 ms | 1232.11 ms | 28.96 ms |
| 7a8b167 | 1217.49 ms | 1247.67 ms | 30.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| e7a30b0 | 24.14 KiB | 1.01 MiB | 1015.20 KiB |
| 795dd39 | 23.75 KiB | 908.16 KiB | 884.41 KiB |
| ea12acf | 23.75 KiB | 974.89 KiB | 951.14 KiB |
| 762a701 | 23.75 KiB | 1022.78 KiB | 999.03 KiB |
| 73c9712 | 23.75 KiB | 908.01 KiB | 884.26 KiB |
| 26f7b17 | 23.75 KiB | 960.93 KiB | 937.19 KiB |
| 924de23 | 23.75 KiB | 947.54 KiB | 923.79 KiB |
| cda95fc | 23.75 KiB | 912.77 KiB | 889.02 KiB |
| 7cc23cf | 23.75 KiB | 913.62 KiB | 889.87 KiB |
| 7a8b167 | 24.14 KiB | 1.01 MiB | 1014.00 KiB |
…opes_set_attributes_logs_batcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Scope's attributes to Sentry Log messages
Follow up to #6830